Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow scrolling on content overflow in smaller viewports #224

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

luqven
Copy link
Contributor

@luqven luqven commented Jun 18, 2024

Description

Updates the Dialog config to allow for scrolling behavior if the contents overflow.

Before

scroll-locked-by-parent-frame.mp4
  • <Dialog> could not scroll when content overflows from the <iframe> parent

After

scroll-overflow-using-sdk-allow-scroll.mp4
  • <Dialog> can be scrolled when the dimensions are larger than the iframe parent

Checklist

  • Read the contributing guidelines.
  • Each commit follows the Conventional Commit spec format.
  • Update the readme (if applicable).
  • Update or add any necessary API documentation (if applicable)
  • All existing unit tests are still passing (if applicable).
  • Add some steps so we can test your bug fix or feature (if applicable).
  • Add new passing unit tests to cover the code introduced by your PR (if applicable).
  • Any breaking changes are specified on the commit on which they are introduced with BREAKING CHANGE in the body of the commit.
  • x ] If this is a big feature with breaking changes, consider opening an issue to discuss first. This is completely up to you, but please keep in mind that your PR might not be accepted.

Copy link

vercel bot commented Jun 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
contentful ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 21, 2024 0:10am
contentful-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 21, 2024 0:10am

@luqven luqven changed the base branch from main to l/PE-5800/configurable-default-source June 18, 2024 02:38
@luqven luqven self-assigned this Jun 18, 2024
@luqven luqven changed the title L/pe 5852/allow overflow feat: allow scrolling on content overflow in smaller viewports Jun 18, 2024
@luqven luqven requested review from a team, longevitytina, mattlaguardia, marco-salcedo and bubble-bub and removed request for a team June 18, 2024 16:04
@luqven luqven marked this pull request as ready for review June 18, 2024 16:04
@luqven luqven requested a review from a team as a code owner June 18, 2024 16:04
@luqven luqven added the enhancement New feature or request label Jun 18, 2024
Copy link
Contributor

@marco-salcedo marco-salcedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Copy link

@longevitytina longevitytina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, works as expected - locally tested ⭐

@luqven luqven force-pushed the l/PE-5800/configurable-default-source branch from b086aed to d56b245 Compare June 20, 2024 23:42
@luqven luqven force-pushed the l/PE-5852/allow-overflow branch from 39cf57f to 7f8a4b7 Compare June 20, 2024 23:43
@luqven luqven force-pushed the l/PE-5800/configurable-default-source branch from d56b245 to 49b8339 Compare June 20, 2024 23:52
@luqven luqven force-pushed the l/PE-5852/allow-overflow branch from 7f8a4b7 to a677f43 Compare June 20, 2024 23:52
@luqven luqven force-pushed the l/PE-5800/configurable-default-source branch from 49b8339 to fa4f4f8 Compare June 20, 2024 23:55
Base automatically changed from l/PE-5800/configurable-default-source to main June 20, 2024 23:56
@luqven luqven force-pushed the l/PE-5852/allow-overflow branch from a677f43 to aee0937 Compare June 20, 2024 23:56
@luqven luqven merged commit b7606aa into main Jun 20, 2024
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants