-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow scrolling on content overflow in smaller viewports #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
luqven
changed the base branch from
main
to
l/PE-5800/configurable-default-source
June 18, 2024 02:38
luqven
changed the title
L/pe 5852/allow overflow
feat: allow scrolling on content overflow in smaller viewports
Jun 18, 2024
luqven
requested review from
a team,
longevitytina,
mattlaguardia,
marco-salcedo and
bubble-bub
and removed request for
a team
June 18, 2024 16:04
marco-salcedo
approved these changes
Jun 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
luqven
force-pushed
the
l/PE-5800/configurable-default-source
branch
from
June 20, 2024 17:38
9e4ba4f
to
b086aed
Compare
luqven
force-pushed
the
l/PE-5852/allow-overflow
branch
from
June 20, 2024 17:39
a5a0ec4
to
39cf57f
Compare
longevitytina
approved these changes
Jun 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice, works as expected - locally tested ⭐
luqven
force-pushed
the
l/PE-5800/configurable-default-source
branch
from
June 20, 2024 23:42
b086aed
to
d56b245
Compare
luqven
force-pushed
the
l/PE-5852/allow-overflow
branch
from
June 20, 2024 23:43
39cf57f
to
7f8a4b7
Compare
luqven
force-pushed
the
l/PE-5800/configurable-default-source
branch
from
June 20, 2024 23:52
d56b245
to
49b8339
Compare
luqven
force-pushed
the
l/PE-5852/allow-overflow
branch
from
June 20, 2024 23:52
7f8a4b7
to
a677f43
Compare
luqven
force-pushed
the
l/PE-5800/configurable-default-source
branch
from
June 20, 2024 23:55
49b8339
to
fa4f4f8
Compare
luqven
force-pushed
the
l/PE-5852/allow-overflow
branch
from
June 20, 2024 23:56
a677f43
to
aee0937
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates the Dialog config to allow for scrolling behavior if the contents overflow.
Before
scroll-locked-by-parent-frame.mp4
<Dialog>
could not scroll when content overflows from the<iframe>
parentAfter
scroll-overflow-using-sdk-allow-scroll.mp4
<Dialog>
can be scrolled when the dimensions are larger than the iframe parentChecklist
BREAKING CHANGE
in the body of the commit.