Skip to content

Commit

Permalink
Added naming rule set
Browse files Browse the repository at this point in the history
  • Loading branch information
imashnake0 committed Jan 21, 2024
1 parent 6968187 commit ddbfbc1
Show file tree
Hide file tree
Showing 2 changed files with 38 additions and 8 deletions.
16 changes: 8 additions & 8 deletions app/src/main/java/com/imashnake/animite/features/theme/Type.kt
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ val manropeFontFamily = FontFamily(
Font(R.font.manrope_semi_bold_italic, FontWeight.SemiBold, FontStyle.Italic),
)

const val baselineShift = 0.2f
const val BASELINE_SHIFT = 0.2f
val AnimiteTypography = Typography(
// - [Home]: Media list headings.
// - [MediaPage]: Media section headings.
Expand All @@ -49,7 +49,7 @@ val AnimiteTypography = Typography(
fontWeight = FontWeight.Bold,
fontSize = 15.sp,
letterSpacing = 0.2.sp,
baselineShift = BaselineShift(baselineShift)
baselineShift = BaselineShift(BASELINE_SHIFT)
),
// - [Home]: Media list item labels.
// - [MediaPage]: Character names.
Expand All @@ -58,15 +58,15 @@ val AnimiteTypography = Typography(
fontFamily = manropeFontFamily,
fontWeight = FontWeight.SemiBold,
lineHeight = 18.sp,
baselineShift = BaselineShift(baselineShift)
baselineShift = BaselineShift(BASELINE_SHIFT)
),
// - [MediaPage]: Media title.
titleLarge = TextStyle(
fontFamily = manropeFontFamily,
fontWeight = FontWeight.Bold,
fontSize = 16.sp,
letterSpacing = 0.2.sp,
baselineShift = BaselineShift(baselineShift)
baselineShift = BaselineShift(BASELINE_SHIFT)
),
// - [MediaPage]: Media description.
// - [SearchItem]: Search list item titles.
Expand All @@ -77,27 +77,27 @@ val AnimiteTypography = Typography(
fontFamily = manropeFontFamily,
fontWeight = FontWeight.Medium,
lineHeight = 22.sp,
baselineShift = BaselineShift(baselineShift)
baselineShift = BaselineShift(BASELINE_SHIFT)
),
// - [MediaPage]: Stat label.
// - [SearchItem]: Search list item season and year.
labelSmall = TextStyle(
fontSize = 12.sp,
fontFamily = manropeFontFamily,
fontWeight = FontWeight.Medium,
baselineShift = BaselineShift(baselineShift)
baselineShift = BaselineShift(BASELINE_SHIFT)
),
// - [MediaPage]: Stat score.
displaySmall = TextStyle(
fontSize = 24.sp,
fontFamily = manropeFontFamily,
fontWeight = FontWeight.Bold,
baselineShift = BaselineShift(baselineShift)
baselineShift = BaselineShift(BASELINE_SHIFT)
),
// - [MediaPage]: Genre.
labelMedium = TextStyle(
fontWeight = FontWeight.Medium,
letterSpacing = (1.3).sp,
baselineShift = BaselineShift(baselineShift)
baselineShift = BaselineShift(BASELINE_SHIFT)
)
)
30 changes: 30 additions & 0 deletions config/detekt/detekt.yml
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,36 @@ exceptions:
TooGenericExceptionCaught:
active: true

naming:
BooleanPropertyNaming:
active: true
ClassNaming:
active: true
ConstructorParameterNaming:
active: true
EnumNaming:
active: true
FunctionMaxLength:
active: true
FunctionParameterNaming:
active: true
InvalidPackageDeclaration:
active: true
LambdaParameterNaming:
active: true
MatchingDeclarationName:
active: true
NoNameShadowing:
active: true
NonBooleanPropertyPrefixedWithIs:
active: true
TopLevelPropertyNaming:
active: true
VariableMaxLength:
active: true
VariableNaming:
active: true

style:
UnusedImports:
active: true
Expand Down

0 comments on commit ddbfbc1

Please sign in to comment.