Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for v1.1.0 release #148

Merged
merged 1 commit into from
Jan 17, 2020
Merged

Conversation

dagwieers
Copy link
Collaborator

Update README and addon.xml for release.

@dagwieers dagwieers added the release Related to release management label Jan 13, 2020
@dagwieers dagwieers added this to the v1.1.0 milestone Jan 13, 2020
@dagwieers
Copy link
Collaborator Author

Here is an overview of everything related to an upcoming v1.1.0 release: https://github.com/im85288/service.upnext/milestone/9?closed=1

@dagwieers
Copy link
Collaborator Author

dagwieers commented Jan 13, 2020

So the question is what do we do with:

@dagwieers
Copy link
Collaborator Author

Rationale for choosing v1.1.0 as the next version. Given version X.Y.Z:

  • X would be used for important new releases (rewrite, breaking changes)
  • Y would be used for new functionality or changes
  • Z would be used for bugfix-only releases

@im85288
Copy link
Owner

im85288 commented Jan 13, 2020

Rationale for choosing v1.1.0 as the next version. Given version X.Y.Z:

  • X would be used for important new releases (rewrite, breaking changes)
  • Y would be used for new functionality or changes
  • Z would be used for bugfix-only releases

Sounds good to me, with regards the open bug reports I guess we can have to leave them for the next release (if indeed we can resolve them). Same for the PR?

The Kodi guys normally complain if I make too frequent releases but it has been a fair bit of time between this and the previous version so all should be fine,

@dagwieers
Copy link
Collaborator Author

I will (finally) call out to existing translators (#112) to fix the remaining issues. In the meantime we can test the current master branch and ask our consumers to perform tests as well?
And maybe release by Wednesday or Thursday?

@im85288
Copy link
Owner

im85288 commented Jan 13, 2020

Yes fine with me for mid week release

@dagwieers dagwieers force-pushed the prepare-1.1.0 branch 3 times, most recently from 0045596 to 8109ec1 Compare January 14, 2020 08:14
@dagwieers
Copy link
Collaborator Author

dagwieers commented Jan 14, 2020

Call out to all stakeholders for testing the master branch: @angelblue05 @sualfred @mediaminister @arvvoid @anxdpanic @CastagnaIT @Dis90 @faush01 @jellyfin @croneter @thebertster @ShaVerZ @venom123 @angus2064 @stathis95194

You can download the ZIP file from: https://github.com/im85288/service.upnext/archive/master.zip
And install it from Settings » Add-ons » Install from zip file

@CastagnaIT
Copy link
Contributor

i did a couple of tests on Kodi 19 with play_url and seem works good

@dagwieers dagwieers force-pushed the prepare-1.1.0 branch 2 times, most recently from 42fe53e to ea33d84 Compare January 14, 2020 21:26
@thebertster
Copy link

Call out to all stakeholders for testing the master branch: @angelblue05 @sualfred @mediaminister @arvvoid @anxdpanic @CastagnaIT @Dis90 @faush01 @jellyfin @croneter @thebertster @ShaVerZ @venom123 @angus2064 @stathis95194

You can download the ZIP file from: https://github.com/im85288/service.upnext/archive/master.zip
And install it from Settings » Add-ons » Install from zip file

Working OK for me in LibreElec 9.2.0 (other than obviously having to do the 1 second adjustment workaround for #139).

@dagwieers
Copy link
Collaborator Author

@thebertster I hope we can focus on issue #139 after upcoming release (as part of restructuring the code). If this was more wildly reported that would no doubt also make a difference on how we would handle this.

@anxdpanic
Copy link
Contributor

All seems good for me as well, tested on Windows and it's now in use on my main OSMC (nightly) installation.

@dagwieers
Copy link
Collaborator Author

@im85288 I wonder if for new installations we should enable the runtime-based notification_time settings instead of the default 30 seconds. Not sure what others think about this?

@im85288
Copy link
Owner

im85288 commented Jan 15, 2020

@dagwieers - Yes that's fine for me, let's see what others think about this. If no objections let's go for it.

@dagwieers dagwieers marked this pull request as ready for review January 17, 2020 02:30
Update README and addon.xml for release.
@dagwieers
Copy link
Collaborator Author

Ready to be merged. Please merge #165 first.
Then this is ready to be tagged as v1.1.0 and released.

@im85288 im85288 merged commit 8fd7cca into im85288:master Jan 17, 2020
@im85288
Copy link
Owner

im85288 commented Jan 17, 2020

release candidate created here: https://github.com/im85288/service.upnext/releases/tag/1.1.0

@dagwieers
Copy link
Collaborator Author

I added the changelog and a ZIP file to the release. While the branch ZIP file works as well, the provided ZIP file is more minimalistic and closer to what will become available from the Kodi repository.

@dagwieers
Copy link
Collaborator Author

@im85288 Can we also push it to the Kodi repository? I can make the PR, but since I am not listed as "provider", you will have to sign off on it. So maybe it is easier if you do it yourself.

As soon as it hits the Kodi repository, the Netflix add-on can start making the modifications to the master branch to make play_url and the new notification_offset work.

@im85288
Copy link
Owner

im85288 commented Jan 17, 2020

@dagwieers Sure no problem I will make the PR tonight once back from work.

@im85288
Copy link
Owner

im85288 commented Jan 17, 2020

@dagwieers PR made to the Kodi Repository: xbmc/repo-scripts#1276

@im85288
Copy link
Owner

im85288 commented Jan 19, 2020

@dagwieers - PR merged: xbmc/repo-scripts#1276 (comment)

Nice work :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release Related to release management
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants