-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare for v1.1.0 release #148
Conversation
Here is an overview of everything related to an upcoming v1.1.0 release: https://github.com/im85288/service.upnext/milestone/9?closed=1 |
So the question is what do we do with:
|
Rationale for choosing v1.1.0 as the next version. Given version X.Y.Z:
|
Sounds good to me, with regards the open bug reports I guess we can have to leave them for the next release (if indeed we can resolve them). Same for the PR? The Kodi guys normally complain if I make too frequent releases but it has been a fair bit of time between this and the previous version so all should be fine, |
I will (finally) call out to existing translators (#112) to fix the remaining issues. In the meantime we can test the current master branch and ask our consumers to perform tests as well? |
Yes fine with me for mid week release |
0045596
to
8109ec1
Compare
Call out to all stakeholders for testing the master branch: @angelblue05 @sualfred @mediaminister @arvvoid @anxdpanic @CastagnaIT @Dis90 @faush01 @jellyfin @croneter @thebertster @ShaVerZ @venom123 @angus2064 @stathis95194 You can download the ZIP file from: https://github.com/im85288/service.upnext/archive/master.zip |
i did a couple of tests on Kodi 19 with play_url and seem works good |
42fe53e
to
ea33d84
Compare
Working OK for me in LibreElec 9.2.0 (other than obviously having to do the 1 second adjustment workaround for #139). |
@thebertster I hope we can focus on issue #139 after upcoming release (as part of restructuring the code). If this was more wildly reported that would no doubt also make a difference on how we would handle this. |
All seems good for me as well, tested on Windows and it's now in use on my main OSMC (nightly) installation. |
@im85288 I wonder if for new installations we should enable the runtime-based notification_time settings instead of the default 30 seconds. Not sure what others think about this? |
ea33d84
to
8ddf92f
Compare
@dagwieers - Yes that's fine for me, let's see what others think about this. If no objections let's go for it. |
8ddf92f
to
c22ad47
Compare
Update README and addon.xml for release.
c22ad47
to
77f3769
Compare
Ready to be merged. Please merge #165 first. |
release candidate created here: https://github.com/im85288/service.upnext/releases/tag/1.1.0 |
I added the changelog and a ZIP file to the release. While the branch ZIP file works as well, the provided ZIP file is more minimalistic and closer to what will become available from the Kodi repository. |
@im85288 Can we also push it to the Kodi repository? I can make the PR, but since I am not listed as "provider", you will have to sign off on it. So maybe it is easier if you do it yourself. As soon as it hits the Kodi repository, the Netflix add-on can start making the modifications to the master branch to make |
@dagwieers Sure no problem I will make the PR tonight once back from work. |
@dagwieers PR made to the Kodi Repository: xbmc/repo-scripts#1276 |
@dagwieers - PR merged: xbmc/repo-scripts#1276 (comment) Nice work :) |
Update README and addon.xml for release.