No notification pop-up appears with Venom #134
Comments
|
Ok, so it appears we did not get any information from the add-on. I would have expected something like this in the logs: If UpNext doesn't get any information from the add-on, it will not show a pop-up. This issue has been reported now a few times, and it was reported it worked with v1.0.1, but not with v1.0.2 or newer. Given that the only changes to v1.0.2 are related to:
So I would need to know what the add-on is sending, and why we aren't receiving it. PS Mind you that a few times now it was suggested this was related to UpNext no longer using Addon Signals, but that is incorrect. Even v1.0.1 is not using Addon Signals, it was removed earlier (39d3661) in v.0.0.9. The issue related to Addon Signals switching from hex to base64 encoding has been dealt with in the v1.0.7 release. (older versions of UpNext should work fine with older versions of Addon Signals though) |
|
I've tried other versions and just gone back to 1.0.1 and still no popup and not moving to next episode. v1.0.1 log; |
|
So what ought to work
But what will definitely not work is Up Next v1.0.6 or older together with Addon Signals v0.0.4 (latest). |
|
Not quite sure what you mean but 1.0.7 doesn't work with any version of Addon Signals (latest). I'm probably not understanding what you mean. |
|
Addon Signals v0.0.3 uses hex encoding. Up Next v1.06 and older uses hex encoding. So if you test anything but v1.0.7, you have to use Addon Signals v.0.0.3 otherwise it is guaranteed to not work and we haven't established anything but that. In other words, the tests you did before using older versions of Up Next don't prove anything unless you also used an older version of Addon Signals. |
|
I was using 1.0.7 when I reported this..... Thanks for your help though, much appreciated. Probably best I leave it..... |
Up Next v1.0.7 works with e.g. the Netflix add-on which is using Addon Signals v0.0.4, so it does work fine (and I am using it daily). We also have integration tests testing Addon Signals v0.0.4 with Up Next to ensure they are compatible. So no issues there. The reported problem here seems to be specific to the implementation of Venom and Seren. |
|
Ah right, I understand. I thought you meant I should try 1.0.7 ensuring Addon Signals 0.0.4, that's where the confusion lay. I thought you meant it should work with that combination whilst using Seren/Venom. It does seem to work with old versions of Kodi though..... Thanks again. |
|
@ShaVerZ Well, it should work for Venom and Seren, but it clearly doesn't. We haven't established the reason for this. I was told it stopped working even with v1.0.2 up to v1.0.6, which would indicate an issue with any of these changes: https://github.com/im85288/service.upnext/compare/1.0.1..1.0.2 But I am not sure if the tests were executed with the correct Addon Signals v0.0.3, so not clear if we can make that conclusion. |
|
If theres anything you want me to try, let me know, I have a few spare FireTV boxes which are not in use. I'm happy to test certain setups if you wish..... |
|
Well, it's working now. I had to drop back to Kodi 18.2 though, no idea why it seems fine with 18.2 but nothing higher..... thought it was worth mentioning. |
|
So using Kodi 18.2 and what version of UpNext and AddonSignals? |
|
I'm not currently home but I could only get 0.1.8 working. v1.0.1 and up didnt. Im assuming it is addon Signals v0.0.3 but I'll need to check when I'm home. |
|
Looking at the Venom code I see various reasons why it would fail: Apart from the fact that Proper python code should not be using broad excepts, and I would suggest that Venom uses tox and pylint for testing for common python issues. Something that worked before could suddenly fail because of changes in behaviour that was not accounted for. Especially Python is susceptible for this. cc @123Venom That said, I don't know if this is the reason for Up Next not working. Adding more log-statements that would give information on what is going on would be helpful as well. Now I don't see any logging from Venom in the logs. Did it ever send out the notification? I wouldn't know. |
|
I got back earlier and noticed it wasnt working, I've tried a combination of installs and none seem to work, I can only assume that Venom has received an update at some point and it has stopped up next working. It doesnt matter which combination you use re: Add on Signals. I could go back and try older versions of Venom but tbh, I cant be assed today ;) |
|
IMO it is better to wait for the developer @123Venom to troubleshoot Venom. |
|
ok I've been looking at this and I'm stumped how I can run v1.0.1 of UpNext without a single issue but both Seren and Venom suffer the same exact problem beyond v1.0.1 with no UpNext notification showing up. I just tried v1.0.7 and logged this |
|
Which version of Kodi have you tested @123Venom and which version of Addon Signals? I cant get any version to work on FireTV Box (gen2)..... |
|
v1.0.1 log...works perfectly! I see what's not transmitted but why idk |
When I implemented UpNext support I was on 18.1...currently on 18.5 and just tested on win pc and Shield and both behave the same way. Anything after v1.0.1 and no notification. 1.0.1 works flawlessly and I've changed no code since nor had reason to till perhaps now. I'd love to get to the bottom of this. And Addon Signals I'm still on 0.0.3 with auto updates off because when that updated to 0.0.4 it also broke but going back to 0.0.3 and all was fine. |
|
@123Venom So you confirm with 100% certainty that v1.0.1 works fine, and v1.0.2 does not? Can you please post full Kodi debug logs rather than fragments? Also previous reports did not include the |
|
SEREN has had an update and Up Next Works, I still can't get it to work with Venom. However, I'm using v1.0.1 with 0.0.0.3 Addon Signals. |
|
@ShaVerZ Sigh, so you are now confirming that Venom does not work with Up Next v1.0.1 using Venom with Addon Signals v0.0.3 ? This would go against all previous reports... |
|
When forwarding to the end of a programme, to see if Up Next works, should you allow a minute or two to the end or longer. I used Seren last night and watched a programme completely and it worked. Perhaps I'm not leaving enough time at the end..... |
|
According to the Seren changelog, Seren v1.6.0 removed Up Next support
|
|
@ShaVerZ Up Next by default is configured to show the pop-up 30 seconds before the end. The master branch now has some heuristics that make this time depend on the length of the video. from 15 seconds before the end to 50 seconds (but configurable to anything you prefer). Update: Some add-ons provide Up Next with their own notification time, I noticed Seren has its own configuration option which also defaults to 30 seconds (but is a slider from 10 to 60). |
|
Well, its 100% working with Seren and I have some settings which resemble Up Next settings. |
|
|
|
I just tested Venom and I can't get it working with v1.0.1 and 0.0.3. Perhaps Seren is using it's own notifications instead of Up Next. |
|
Well, the Seren code at https://github.com/nixgates/plugin.video.seren is incomplete. The code refers to files that do not exist in the tree. But it is clear they moved to their own implementation rather than use Up Next. |
|
Same problem here, This is an excerpt from the log with the relevant lines 2020-01-06 20:54:06.279 T:140210973230848 NOTICE: [service.upnext] Monitor -> Calling autoplayback totaltime - playtime is 59.3798828125 Kind Regards, |
|
Download the following versions and install via zip within Kodi, make sure you turn auto update off for these addons..... https://drive.google.com/folderview?id=1ShAejmjxJVsiua8gRL3-84pLBmPVb9vb |
Tested on kodi 18.5 Will test other Tv shows Thanks for your help |
Tested on other Tv and worked ok, although it seems strange that it does not work in the first TV show I tested, in which it previously worked fine. 2020-01-06 23:21:54.009 T:140607456528128 NOTICE: UP NEXT Api -> log : Got details of next up episode {"jsonrpc": "2.0", "id": 1, "result": {"episodes": [{"plot": "Primer cap\u00edtulo de la |
As far as I know, nobody from the Up Next project is looking into this as we have no developers using Venom. We also believe the issue to be in Venom (possibly triggered by changes in v1.0.2). Up Next is working fine for other add-ons. A resolution will have to come from the Venom developers looking into what is going on under the hood. We can help analysing data, but it seems the default logging does not expose the problem. |
|
The reason why it fails from your logs with v1.0.2 is because of this error: The only code where this could happen is: service.upnext/resources/lib/api.py Lines 40 to 45 in 570239b This code was indeed added to v1.0.2 and we fixed this in v1.0.4 (#68) by using more defensive code: service.upnext/resources/lib/api.py Lines 54 to 60 in 513ef9d But that is not the reason why things are failing in v1.0.4+ (it might still be because of changes in v1.0.2). In fact it apparently needs this |
dagwieers
changed the title
|
@123Venom We have updated the documentation at: https://github.com/im85288/service.upnext/wiki/Integration It includes example source code and details on how to integrate with Up Next without needing AddonSignals. Maybe you have more luck with this more elegant implementation. It is easier to integrate since it only requires to send the signal using standard JSONRPC calls, and no longer needs to wait for receiving the signal. Up Next will call out to the add-on directly. |
|
Is this still an issue? And if so, who is able and willing to troubleshoot this? |
|
hi @dagwieers, |
|
Please test the upcoming v1.1.3 release by testing PR #217 and reporting back. |
|
Unfortunately same results using Addonon-Signals v0.0.6 with UpNext v1.1.3 and while continual playback works fine there's no UpNext pop-up. The only combo I've been able to receive the UpNext pop-up to date has been Addon-Signals v0.0.3 with UpNext v1.01. I just reverted to those former versions and it's back to working again. Here's the [service.upnext] log capture using those latest versions mentioned and the data exchange looks correct. |
|
The reason why it doesn't show a popup is because UpNext is assuming that any playlist item is an item from the Kodi library, with an associated episodeid and tvshowid. Even though the video addon is sending the episode details to UpNext, it is being ignored and the playlist item video info details are being used instead. Unfortunately the playlist item does not contain any useful video details for UpNext to use and so UpNext silently exits and just lets the playlist keep playing. The reason why it works in UpNext v1.0.1 is because that version did not handle playlist items, and so it will correctly use the addon data that was sent to UpNext. As a general issue, it was a little tricky to fix, as simply using the addon data would mean that the playlist would be lost, which may or may not be significant to the way the addon works. In order to fix this, I elected to use the addon data for info, but use the playlist for actually playing the stream, based on the reasoning that there was probably a purpose as to why an addon or user went to the trouble of creating/playing a playlist of video streams from an addon in the first place, and that UpNext should respect that action without destroying the playlist by directly playing the next stream. However, for this specific case, as it works in UpNext v1.0.1, we can assume that losing the playlist is not an issue (this is probably not an issue for most addons, as the combination of the addon data and the functionality of UpNext effectively acts to recreate the playlist on the fly, but only with the current/next episode). As such the following small change should fix the problem: Replace playitem.py#L43-L44 with |
|
@MoojMidge sorry bud idk how I missed a message of this post but I did till I chose to peak on my own. Anyway I tested your code change and it now works brilliantly as it did the older version I mentioned. Any chance of getting this incorporated into a future release? I could do my own mod of it but for a couple lines of code seems pointless and confusing for users if I can convince the UpNext boys to be my new best friend...lol..thoughts? |
I think more may need to be fixed here. The suggested change resolves the issue you identified by essentially disabling playlist handling if addon data has been sent to UpNext. I don't think this should cause any issues, but playlist handling was implemented in this manner, and presumably for a good reason, in PR #46 almost a year and a half ago. I don't know if there are any addons that actually rely on the current behaviour i.e. UpNext using the addon data if there only one item playing, but ignoring it if there is a playlist of addon urls that the addon has created. |
|
Have been testing a simple fix for this, for a while now, that appears to satisfy the pre-v1.0.2 use cases while not breaking for any addon relying on functionality from PR #46 (hypothetically - haven't actually seen anything that is reliant on this behaviour) The proposed logic is:
If the above makes sense, can create a PR to try and fix this in the current code. |
|
@MoojMidge make sense to me, would appreciate if you can make a PR to try and resolve the tangle we have gotten into. |
|
Done: #247 Only caveat is the code comes from a different branch, and needs some testing. |
|
I'm not able to get this add-on working with Fen. I think I am having the same issue as described here in this thread. No popup nor does the next episode play. I tried making the changes MoojMidge recommended but it looks like the code has changed a bit since then. Is this addon supposed to work out of the box with video addons such as Fen and Venom? Am I doing something wrong? |
I'd venture a guess your issue is more than likely this one, it surely was mine per log data when it broke and it's still an issue. I managed to tweak things so |
@123Venom What did you end up doing for that? Using OnAVStart is an easy fix that should work for most cases and I can create a PR to fix #238. Were there other problems you were having with UpNext? @ambulancePilot I don't use Fen or Venom so I don't know if it was intended that they work with UpNext, but in general support for UpNext needs to be implemented by the addons you are using, unless they use playlists, which is what this issue and the aforementioned changes were about. The changes were already implemented so if there is still a problem then logs need to be provided, otherwise it's just about impossible to know what is happening. |
FireTV Box (gen.2) 4k
Kodi 18.5
Up Next 1.0.7 (Latest)
No notification popup and it seems to have stopped going on to the next episode. The playlist seems to be created within the addon, when viewing the playlist manager.
I couldnt find the exact information you required but the .log link is;
https://pastebin.com/GPvBYptu
I hope this helps and that I've provided what you need.
The text was updated successfully, but these errors were encountered: