Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented the Template View pattern (#1320) #3110

Merged
merged 4 commits into from
Jan 6, 2025

Conversation

malak-elbanna
Copy link
Contributor

Issue #1320

I've implemented the Template View pattern according to the criteria and resources given in the issue description. More details about the pattern and the specifics of the implementation can be found in the README file attached with this PR.

Copy link
Owner

@iluwatar iluwatar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additionally, please use Java package name com.iluwatar

templateview/README.md Outdated Show resolved Hide resolved
@malak-elbanna
Copy link
Contributor Author

Hi @iluwatar, thank you for your comments. I've addressed them!

iluwatar
iluwatar previously approved these changes Jan 6, 2025
@iluwatar iluwatar merged commit 5ba4570 into iluwatar:master Jan 6, 2025
1 check passed
@iluwatar
Copy link
Owner

iluwatar commented Jan 6, 2025

Looks good! Thank you for the contribution 🎉

@all-contributors please add @malak-elbanna for code

Copy link
Contributor

@iluwatar

I've put up a pull request to add @malak-elbanna! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants