deduplicate ilios user records before processing their enrollment. #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
while at it, i reworked how ilios user records without campus ids are filter out - i made that a pre-processing step to deduplication.
stopfstedt
force-pushed
the
72_deal_with_duplicate_user_accounts
branch
from
2076130 to
c793b2c
Compare
- corrects docblock. - adds assertion to confirm that no enrolment happened.
stopfstedt
force-pushed
the
72_deal_with_duplicate_user_accounts
branch
from
5fbf4a8 to
32c4c1e
Compare
stopfstedt
force-pushed
the
72_deal_with_duplicate_user_accounts
branch
from
32c4c1e to
925c48a
Compare
|
Thanks @stopfstedt. The code looks good to me. I just wonder that it is really impossible or too hard to implement this on the API's endpoint. It seems to me that if the Ilios's user API is returning these users with missing or duplicate |
|
@ctam we could add a filter to remove the users with a missing ID, but I doubt it would save much. I wouldn't want to remove duplicates with any sort of filter because, as shown here, the decision about which account to use remains a local one and is up to the API consumer. Given this is an automated, and not a user facing process, this seems like a good way forward. |
jrjohnson
reviewed
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #72