Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes scoping issue with closures by explicitly passing variable into it. #74

Merged
merged 2 commits into from
Jan 22, 2025
Merged

fixes scoping issue with closures by explicitly passing variable into it. #74

merged 2 commits into from
Jan 22, 2025

Conversation

stopfstedt
Copy link
Member

fixes #73

@stopfstedt stopfstedt requested a review from jrjohnson January 22, 2025 01:13
jrjohnson
jrjohnson approved these changes Jan 22, 2025
View reviewed changes
Copy link
Member

@jrjohnson jrjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gnarly closure, +1 fix

@jrjohnson jrjohnson merged commit 76fc540 into ilios:MOODLE_404_STABLE Jan 22, 2025
4 checks passed
@stopfstedt stopfstedt deleted the closure_fix branch January 22, 2025 17:31
@stopfstedt stopfstedt mentioned this pull request Jan 22, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrjohnson jrjohnson jrjohnson approved these changes

Assignees

@jrjohnson jrjohnson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stopfstedt @jrjohnson