Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moodle 4.4 upgrade #60

Merged
merged 19 commits into from
Oct 11, 2024
Merged

Moodle 4.4 upgrade #60

merged 19 commits into from
Oct 11, 2024

Conversation

stopfstedt
Copy link
Member

  • refactored Ilios API client
  • added test coverage

@stopfstedt
minimal upgrade to Moodle 4.4.
bd03d37
@stopfstedt
adds the new Ilios API client and supporting infrastructure.
7dd3c3d 
copy/pasted from tool_ilioscategoryassigment.
@stopfstedt
wip: replace ilios client in enrollment plugin
50adb11
@stopfstedt
rm obsolete dependency on ilios_apiclient plugin.
60a88bb 
the functionality we got from this dependency has been absorbed into this plugin.
fixes typo in release info and bumps version while at it.
@stopfstedt
updates copyright annotations in source files.
5c5bdaf 
i'm dropping the year info from the copyright. it's unnecessary.
this code has always, and will always, "belong to" the regents.
@stopfstedt
adds test coverage for enrolment workflows.
0a591ce
@stopfstedt
adds unenrolment notification back in.
e7b821c
@stopfstedt
corrects closing of users loop.
f3d027e 
see ilios#50

this addresses the regression outline in
@stopfstedt
put output to Ilios API (http requests) under test coverage.
658a83d 
cleanup of test vectors while at it.
@stopfstedt
put logging output from sync under test coverage.
f20f20e
@stopfstedt
add test scenario for changing enrolment status.
4b1ec45
@stopfstedt
test return value of sync method.
a3e5f4a
@stopfstedt
renamed test methods to reflect the method-under-test.
39ef9e7
@stopfstedt
add test coverage for disabled sync run.
ece9e2c 
fixes unrelated linting errors while at it.
@stopfstedt
adds more user sync tests.
fdc7dcc 
do some cleanup on pre-existing tests while at it.
@stopfstedt
stub out future tests.
4614406 
these tests cover areas of the process that haven't changed during this
refactor, but that should be covered with tests nonetheless.
@stopfstedt
version and maturity bump.
39f2546
@stopfstedt
adds test to verify that disabled instances are not processed.
875722d
@stopfstedt stopfstedt mentioned this pull request Oct 9, 2024
Closed
@stopfstedt stopfstedt requested a review from jrjohnson October 10, 2024 19:32
jrjohnson
jrjohnson reviewed Oct 11, 2024
View reviewed changes
Copy link
Member

@jrjohnson jrjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of questions on some specific parts.

classes/ilios.php Show resolved Hide resolved
classes/ilios.php Outdated Show resolved Hide resolved
classes/ilios.php Show resolved Hide resolved
edit.php Show resolved Hide resolved
lang/en_us/enrol_ilios.php Show resolved Hide resolved
tests/helper_test.php Show resolved Hide resolved
tests/lib_test.php Show resolved Hide resolved
@stopfstedt
rm unnecessary input arg.
8e17090 
ilios::get() is never called with additional options, so we can just pass the
JWT token in an array without blending things first.
@stopfstedt stopfstedt requested a review from jrjohnson October 11, 2024 17:12
jrjohnson
jrjohnson approved these changes Oct 11, 2024
View reviewed changes
Copy link
Member

@jrjohnson jrjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super approve!

classes/ilios.php Show resolved Hide resolved
edit.php Show resolved Hide resolved
@jrjohnson jrjohnson merged commit b0af9bd into ilios:MOODLE_404_STABLE Oct 11, 2024
4 checks passed
@stopfstedt stopfstedt deleted the moodle44upgradeforreal branch October 11, 2024 19:53
@stopfstedt stopfstedt mentioned this pull request Oct 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrjohnson jrjohnson jrjohnson approved these changes

Assignees

@jrjohnson jrjohnson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stopfstedt @jrjohnson