Correct Rollover Year Options #8333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Courses can always be rolled over into the previous, current, and several future years. The academic year doesn't map to the calendar year, so we always need to ensure we're starting at the right place otherwise the current year will disappear in January. From January through the end of June we need to back up even further because the previous academic year is now two years behind the current calendar year.
jrjohnson
requested review from
michaelchadwick and
stopfstedt
as code owners
dartajax
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Courses can always be rolled over into the previous, current, and several future years.
The academic year doesn't map to the calendar year, so we always need to ensure we're starting at the right place otherwise the current year will disappear in January.
From January through the end of June we need to back up even further because the previous academic year is now two years behind the current calendar year.
Fixes ilios/ilios#5963