Ember cli string helpers replacement #8320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…we need. most of it lifted verbatim from that library.
stopfstedt
requested review from
jrjohnson and
michaelchadwick
as code owners
|
|
||
| let expected = 'Hi'; | ||
|
|
||
| assert.dom().hasText(expected, 'capitalizes a single string'); |
There was a problem hiding this comment.
I like seeing test messages like these!
| assert.dom('h1').hasText('Hello World', 'html string is correctly rendered'); | ||
| }); | ||
|
|
||
| test('It safely renders CSS classes from a property', async function (assert) { |
There was a problem hiding this comment.
What's an example where this would be used? I've never used any htmlSafe method on a CSS class before.
There was a problem hiding this comment.
Something like
where if we don't mark the string assafe Ember will escape it to prevent css injection. If you put the class into the template that's fine, but if you attempt to do work on these properties in a getter or some other JS property Ember will call shenanigans.
jrjohnson
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes ilios/ilios#5927