Add Foreground and Background text color options #1240
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ember-simple-charts ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Some varieties involving setting no colors, one or the other color, and even adding some mild transparency for the background rectangle. |
|
Closing this as the approach for legibility took a different turn. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make the text labels easier to read, adding the ability to change both the foreground and background color would be helpful. I've only done the
Donutchart so far, but if this is useful, I can do the rest. Still a bug with handling clicking on label vs slice, but otherwise working.