donut and pie charts now do not animate if they are displayed as icons #1236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ember-simple-charts ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
michaelchadwick
force-pushed
the
1234-remove-icon-animation
branch
from
d6d4b05 to
0120b8e
Compare
stopfstedt
approved these changes
Jan 16, 2025
| @@ -41,8 +45,6 @@ export default class SimpleChartDonut extends Component { | |||
| ]); | |||
| const donutWidth = width * 0.2; | |||
|
|
|||
| this.loading = true; | |||
michaelchadwick
force-pushed
the
1234-remove-icon-animation
branch
from
274883d to
bf6e1ba
Compare
jrjohnson
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1234