Merge pull request #1238 from jrjohnson/account-for-zero

Restore Check for Zero Size
ilios · Jan 16, 2025 · c4b5d8f · c4b5d8f
2 parents 022c661 + d89fada
commit c4b5d8f
Show file tree

Hide file tree

Showing 5 changed files with 15 additions and 0 deletions.
diff --git a/ember-simple-charts/src/components/simple-chart-cluster.js b/ember-simple-charts/src/components/simple-chart-cluster.js
@@ -25,6 +25,9 @@ export default class SimpleChartCluster extends Component {
         containerWidth,
       ],
     ) => {
+      if (!containerHeight || !containerWidth) {
+        return;
+      }
       this.loading = true;
       const height = Math.min(containerHeight, containerWidth) || 0;
       const width = Math.min(containerHeight, containerWidth) || 0;

diff --git a/ember-simple-charts/src/components/simple-chart-donut.js b/ember-simple-charts/src/components/simple-chart-donut.js
@@ -44,6 +44,9 @@ export default class SimpleChartDonut extends Component {
         containerWidth,
       ],
     ) => {
+      if (!containerHeight || !containerWidth) {
+        return;
+      }
       this.loadingPromise = null;
       const height = Math.min(containerHeight, containerWidth) || 0;
       const width = Math.min(containerHeight, containerWidth) || 0;

diff --git a/ember-simple-charts/src/components/simple-chart-pack.js b/ember-simple-charts/src/components/simple-chart-pack.js
@@ -25,6 +25,9 @@ export default class SimpleChartPack extends Component {
         containerWidth,
       ],
     ) => {
+      if (!containerHeight || !containerWidth) {
+        return;
+      }
       this.loading = true;
       const height = Math.min(containerHeight, containerWidth) || 0;
       const width = Math.min(containerHeight, containerWidth) || 0;

diff --git a/ember-simple-charts/src/components/simple-chart-pie.js b/ember-simple-charts/src/components/simple-chart-pie.js
@@ -44,6 +44,9 @@ export default class SimpleChartPie extends Component {
         containerWidth,
       ],
     ) => {
+      if (!containerHeight || !containerWidth) {
+        return;
+      }
       this.loadingPromise = null;
       const height = Math.min(containerHeight, containerWidth) || 0;
       const width = Math.min(containerHeight, containerWidth) || 0;

diff --git a/ember-simple-charts/src/components/simple-chart-tree.js b/ember-simple-charts/src/components/simple-chart-tree.js
@@ -25,6 +25,9 @@ export default class SimpleChartTree extends Component {
         containerWidth,
       ],
     ) => {
+      if (!containerHeight || !containerWidth) {
+        return;
+      }
       this.loading = true;
       const height = Math.min(containerHeight, containerWidth) || 0;
       const width = Math.min(containerHeight, containerWidth) || 0;