Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set no relief to window control button #29

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

alunux
Copy link
Contributor

@alunux alunux commented Sep 14, 2018

Fixed #16. Also it plays nice with panel look and feel. Tested on built-in theme and Qogir theme.

Before - built-in theme:
image

After - built-in theme:
image

Before - Qogir theme:
image

After - Qogir theme:
image

When the button was drawn with a relief, the applet's color didn't
match with panel theme. This commit fixed this issue by setting
the value of Gtk.Button's relief property to Gtk.ReliefStyle.NONE.
@rbreaves
Copy link

rbreaves commented Sep 5, 2021

This would be a nice addition indeed. It kinda annoys me to see a broken theme - even when not maximized I was about to do my own investigation but it looks like this PR has been waiting to be merged for some time already.

Just to lay out all of the dependencies for compiling on something like Ubuntu Budgie since it is not mentioned any where.

sudo apt install meson ninja-build libgtk-3-dev libpeas-dev budgie-core-dev libwnck-3-dev

If brew is installed then remove pkg-config, at least temporarily

brew remove --ignore-dependencies pkg-config

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Window buttons not using theme styles
2 participants