Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update annotation.rb #70

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update annotation.rb #70

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e5f495d
Update annotation.rb
minusdavid Mar 20, 2018
3772304
Update annotation.rb
minusdavid Mar 20, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion lib/iiif/presentation/annotation.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,11 @@ class Annotation < AbstractResource
TYPE = 'oa:Annotation'

def required_keys
super + %w{ motivation }
super + %w{ motivation on }
end

def string_only_keys
super + %w{ on }
end

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you're missing an end for this method. You aren't by chance a Python programmer are you 😉 ?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooops!

I'm actually more of a Perl programmer, but I was working on Python earlier in the day, so maybe that was it!

Actually, looking at my local copy, I've got the "end" in there. I didn't copy and paste so my head must have still been in Python mode ;)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added another commit to fix that missing "end".

I'm using the Github browser editor out of laziness/a desire for speed, but I admit I'm not so familiar with the web interface. Used to doing everything on the CLI...

def abstract_resource_only_keys
Expand Down