asyncio #31
Open
asyncio #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: bwl <[email protected]>
whybeyoung
requested changes
May 30, 2024
| code = content['header']['code'] | ||
| logger.debug(f"sid: {content['header']['sid']}, code: {code}") | ||
| if code != 0: | ||
| logger.error(content['header']['message']) |
There was a problem hiding this comment.
- 如果这里错误不为0，不用continune
- 不要print
There was a problem hiding this comment.
这里 code不为 应该无法走后门的逻辑了，可以本地模拟下错误，比如传一个错误的数据类型看下这里报错如何，测试下
sparkai/llm/llm.py
Outdated
| if "usage" in data: | ||
| final_frame = True | ||
| llm_output["token_usage"] = data['usage']['text'] | ||
| if 'text' not in data['choices'] and not final_frame: |
There was a problem hiding this comment.
usage和text确定是在两帧返回吗？确认下
sparkai/llm/llm.py
Outdated
| ) | ||
| return aws | ||
| except websockets.ConnectionClosed as e: | ||
| print(f"Connection closed unexpectedly:{e}") |
sparkai/llm/llm.py
Outdated
| except websockets.ConnectionClosed as e: | ||
| print(f"Connection closed unexpectedly:{e}") | ||
| except Exception as e: | ||
| print(f"An error occurred: {e}") |
Signed-off-by: bwl <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.