Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify language around public / private extension conflicts #642

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jhoyla
Copy link

@jhoyla jhoyla commented Jan 15, 2025

Previous language could be interpreted to mean that public and private extensions are allowed to conflict.

Comment on lines +1897 to +1898
type. (For the purposes of this check, a public extension MUST NOT conflict
with a private extension.) If so, the Aggregator MUST mark the input share as
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand the purpose of this parenthetical statement. As jhoyla notes, the old version was ambiguous. The new version is more correct, but now is redundant and I think we should delete it.

Suggested change
type. (For the purposes of this check, a public extension MUST NOT conflict
with a private extension.) If so, the Aggregator MUST mark the input share as
type. If so, the Aggregator MUST mark the input share as

@cjpatton do you remember why that sentence in parentheses was ever there?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't recall discussing this paranthetical in particular.

I think we're attempting to define the following algorithm: let $S$ be the multiset of extension points among the public and private extension fields: if any value occurs twice in $S$, then reject.

I would probably clarify this as follows: "if any extension type occurs twice across the public and private extension fields, then reject".

@cjpatton cjpatton added editorial The issue raised is purely editorial (i.e., doesn't impact implementations). draft-14 labels Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
draft-14 editorial The issue raised is purely editorial (i.e., doesn't impact implementations).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants