Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parameters fix #40

Merged
merged 4 commits into from
Dec 29, 2023
Merged

Parameters fix #40

merged 4 commits into from
Dec 29, 2023

Conversation

iWebster28
Copy link
Contributor

@iWebster28 iWebster28 commented Oct 9, 2023 •
edited
Loading

Address #37. Quick fix to allow parameters to be used. Can be improved.

ideoforms
ideoforms approved these changes Dec 29, 2023
View reviewed changes
Copy link
Owner

@ideoforms ideoforms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'll merge this now for efficiency, and will then add a couple of tweaks (specifically adding a scan_parameters flag so that this behaviour can be toggled on/off as desired).

@ideoforms ideoforms merged commit 0520ec3 into ideoforms:master Dec 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ideoforms ideoforms ideoforms approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iWebster28 @ideoforms