-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cmd line arg to suppress header output #29669
base: next
Are you sure you want to change the base?
Conversation
ca8cd71
to
1c1b30b
Compare
@@ -247,6 +247,10 @@ MooseApp::validParams() | |||
"Continue the calculation. Without <file base>, the most recent recovery file will be used"); | |||
params.setGlobalCommandLineParam("recover"); | |||
|
|||
params.addCommandLineParam<bool>( | |||
"suppress_header", "--suppress-header", "Flag to print the App header"); | |||
params.setGlobalCommandLineParam("suppress_header"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ugh, this comment got stuck in "review", sorry it didn't go out...anyways, heres the command line and old comment...
@loganharbour This PR builds on #29663 , so it's a bit convoluted with that update, but here is the cmd line I'm trying to add. I would like to be able to optionally suppress the header being printed. I tried to use CommonOutputAction
, similar to #29665, but it's not built at this point (I think?).
Job Coverage, step Generate coverage on 3ba6e2e wanted to post the following: Framework coverage
Modules coverageCoverage did not change Full coverage reportsReports
Warnings
This comment will be updated on new commits. |
d641b16
to
e25f75a
Compare
e25f75a
to
3ba6e2e
Compare
Can someone pass judgement on including a test on this @GiudGiud @loganharbour @pbehne ? The simplest is a |
I think we should just make another dummy app for it so that we don't get a header in every moose_test-opt run |
Could also put a header in |
I don't like testing framework content outside of the framework. misc testing doesn't contribute to framework coverage for example. If we don't want another app, we can just do something silly like
but we've done worse. |
Job Documentation, step Docs: sync website on 3ba6e2e wanted to post the following: View the site here This comment will be updated on new commits. |
Combined #29663 into this. Changed the header output stream to
_console
, and added command line arg to suppress header output. Testing requires aheader()
somewhere, which was advised against, so this doesn't have an associated test. Was tested locally using aheader()
inMooseTestApp
.Closes #29662