Updates to concrete moisture transport models #225
Conversation
|
Job Precheck on e109f2e wanted to post the following: Your code requires style changes. A patch was auto generated and copied here
Alternatively, with your repository up to date and in the top level of your repository:
|
|
Based on discussions with @SudiptaBiswas and some new papers we have looked at, I'm not making the changes to the PDE terms that I had in the original version of this PR. We still need to have further discussions on this topic. |
| @@ -66,8 +66,6 @@ ConcreteThermalMoisture::validParams() | |||
| params.addParam<Real>("aggregate_mass", 1877.0, "aggregate mass (kg) per m^3"); | |||
| params.addParam<Real>("water_to_cement_ratio", 0.43, "water to cement ratio"); | |||
| params.addParam<Real>("concrete_cure_time", 23.0, "concrete curing time in days"); | |||
| params.addDeprecatedParam<Real>( | |||
| "aggregate_vol_fraction", 0.7, "volumetric fraction of aggregates", "Not used"); | |||
There was a problem hiding this comment.
This is failing the ASR assessment cases.
There was a problem hiding this comment.
Yeah, I'll remove that commit from this PR. It's because there hasn't been a successful update of the blackbear submodule in grizzly for a while. I almost have that fixed.
…lab#223 This BC has an equation that computes the relative humidity to be prescribed using a Dirichlet BC from a formula that is dependent on the temperature, which should be converted from C to K. However, the code only did that conversion in one of the places where the temperature was used. This corrects that error.
1) Delete the existing 2D test 2) Add a coarse, fast-running 1D test of the MAQBETH experiment. This runs with larger time steps and a coarser mesh than we would prefer, but the results are reasonably close to a more refined version, and reasonably close to the published experimental results. 3) Add a Python script for plotting the results of this test at various times reported in the paper on this experiment.
ref #216 ref #223 ref #224
This set of changes resolves several issues with the models for moisture transport in concrete: