Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding val-1fa and val-1fb verification cases #22

Merged

Conversation

singhgp4321
Copy link
Collaborator

Ref: #12

@singhgp4321 singhgp4321 force-pushed the val-1f_heat_conduction_with_generation branch from 0a57ee0 to 86a849c Compare August 1, 2022 22:13
@moosebuild
Copy link

moosebuild commented Aug 1, 2022

Job Documentation on 1aed3b0 wanted to post the following:

View the site here

This comment will be updated on new commits.

@singhgp4321 singhgp4321 force-pushed the val-1f_heat_conduction_with_generation branch 3 times, most recently from b34d2e0 to 227a3cc Compare August 2, 2022 19:35
@singhgp4321
Copy link
Collaborator Author

@cticenhour It's still failing the documentation test although I made those updates in the yml file.

@cticenhour
Copy link
Member

I will take a closer look! Thanks for the heads up.

Copy link
Member

@cticenhour cticenhour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't make these suggestions in the general GitHub interface for some reason, but I would also make these changes:

diff --git a/doc/config.yml b/doc/config.yml
index 4832f50..59fb4ac 100644
--- a/doc/config.yml
+++ b/doc/config.yml
@@ -16,7 +16,7 @@ Extensions:
             Documentation:
               TMAP8-only Syntax: syntax/tmap_only.md
               Complete Code Syntax: syntax/index.md
-            Software Quality: sqa/index.md
+            Software Quality: /sqa/index.md
     MooseDocs.extensions.appsyntax:
         executable: ${ROOT_DIR}
         includes:
diff --git a/doc/sqa_reports.yml b/doc/sqa_reports.yml
index cdcf159..bb89603 100644
--- a/doc/sqa_reports.yml
+++ b/doc/sqa_reports.yml
@@ -24,5 +24,6 @@ Requirements:
         working_dirs:
             - ${ROOT_DIR}/doc/content
             - ${MOOSE_DIR}/framework/doc/content
+            - ${MOOSE_DIR}/modules/heat_conduction/doc/content
         directories:
             - ${ROOT_DIR}/test

doc/config.yml Show resolved Hide resolved
doc/config.yml Show resolved Hide resolved
@cticenhour
Copy link
Member

All of these changes should fix both the SQA fail and the general documentation build fail.

@singhgp4321 singhgp4321 force-pushed the val-1f_heat_conduction_with_generation branch from 227a3cc to 1aed3b0 Compare August 16, 2022 03:07
@cticenhour
Copy link
Member

@singhgp4321 Just checking - are you still pulling the verification documentation text from the older TMAP manual?

It seems that branch protection rules are preventing me from merging this right now, even though I have write access. Pinging @lindsayad about it, though it might be a bit before he is in a position to respond.

@lindsayad lindsayad merged commit 7c9406e into idaholab:devel Aug 16, 2022
@singhgp4321
Copy link
Collaborator Author

@cticenhour For this MR I wrote the documentation text, although I try to use what is already in the V&V report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants