-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation for validation cases 1a-1d #18
Conversation
@singhgp4321 thank you so much for adding these contributions. Can you make sure that your commit contains an issue reference? E.g. you can run |
503c81d
to
99f0103
Compare
@lindsayad Issue reference added. |
99f0103
to
a38ea6a
Compare
Job Documentation on 8900cea wanted to post the following: View the site here This comment will be updated on new commits. |
The |
a38ea6a
to
65d60a5
Compare
val-1d.md was mistakenly deleted, now it's back. Still need to add a couple of comparison plots in that md file; working on it . . . |
if you want some help looking into |
65d60a5
to
ede79d9
Compare
8e4056e
to
4d258bf
Compare
For some reason, the comparison of val-1d results with the analytical solution does not look impressive (val-1d_comparison_diffusion.png). I suspect that some parameter used in the analytical solution (see comparison_val-1d.py) is not what it should be. |
cf044bd
to
8900cea
Compare
This is really nice documentation @singhgp4321. I'm super impressed. Probably better than any doc I've ever made 😆 We should try and look into the 1d discrepancies, but that is another task. Thank you!! |
Haha 😆 You're welcome! Let's touch base sometime next week for implementing the other validation cases. You had mentioned that probably we'll need to develop kernels for the other cases. |
Sounds good! Just let me know when you want to meetup. I will be out of
town on Monday but should be available on other days
…On Fri, May 13, 2022 at 8:25 AM Gyanender Singh ***@***.***> wrote:
Haha 😆 You're welcome! Let's touch base sometime next week for
implementing the other validation cases. You had mentioned that probably
we'll need to develop kernels for the other cases.
—
Reply to this email directly, view it on GitHub
<#18 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACOGA4CP4NQJF66AEZ6TCMTVJZX6LANCNFSM5RMH25FQ>
.
You are receiving this because you modified the open/close state.Message
ID: ***@***.***>
|
#12
Add documentation for case 1a, 1b, 1c and 1d.