Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement backend management CLI #894

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Implement backend management CLI #894

wants to merge 1 commit into from
+393 −0

Conversation

kerthical
Copy link
Contributor

ICTSC Regaliaのバックエンドを触れるCLIを作成しました。実質的にcurlの薄いラッパーです。 #893

@kerthical kerthical self-assigned this Dec 25, 2024
@github-actions GitHub Actions
Copy link
Contributor

The latest Buf updates on your PR. Results from workflow Proto CI Pipeline / lint (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedDec 25, 2024, 9:54 AM

@kerthical kerthical requested a review from tosuke December 25, 2024 09:54
@kerthical kerthical linked an issue Dec 25, 2024 that may be closed by this pull request
Admin API を操作する CLI #893
Open
@kerthical kerthical added enhancement New feature or request backend Backend issues go Pull requests that update Go code labels Dec 25, 2024
@kerthical kerthical marked this pull request as ready for review January 6, 2025 17:45
tosuke
tosuke requested changes Jan 12, 2025
View reviewed changes
Copy link
Collaborator

@tosuke tosuke left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lint は通る状態にしてからレビューに出してほしいです 🙇

backend/cmd/ictscli/cmd/team/create.go
},
}

func init() {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

初期化順序がわかりにくくなるので init は使わないでほしいです。func createCmd()を定義するなどがよさそう

@kerthical
Copy link
Contributor Author

lint は通る状態にしてからレビューに出してほしいです 🙇

lintは通ってませんか…？とはいえコンフリクトの解決とレビュー項目については時間がある時に修正しておきます。

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tosuke tosuke tosuke requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@kerthical kerthical

Labels
backend Backend issues enhancement New feature or request go Pull requests that update Go code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Admin API を操作する CLI
2 participants
@kerthical @tosuke