Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: One row calendar top bar on small screens #1160

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

IsaacNguyen
Copy link
Contributor

@IsaacNguyen IsaacNguyen commented Feb 12, 2025

Summary

Changed the "FINALS" button to become a smaller icon on smaller screens, preventing it from becoming two rows.

BEFORE:
image

AFTER:

  • When the icon is not pressed
image
  • When the icon IS pressed
image

Test Plan

  • Ensure works properly on all kinds of small devices

Issues

  • I make it become an icon at around a 400px width, but it still becomes two rows for very very small screens. But I doubt there are even screens this tiny. If there are, I can change it further.
    • image
  • Could change the icon but I felt like this one was suiting.

Closes #1026

@IsaacNguyen IsaacNguyen self-assigned this Feb 12, 2025
Copy link
Member

@KevinWu098 KevinWu098 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this PR Isaac! Very happy that we're address this area of the UI.

I've left some comments regarding some code consistency and visual clarity 🫡

@MinhxNguyen7
Copy link
Member

Border not visible in light mode

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Calendar top bar becomes two rows for smaller screens
3 participants