rocm: add reason for disabled component #219
Open
+4
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Treece-Burgess
approved these changes
Aug 21, 2024
There was a problem hiding this comment.
I personally would add a format specifier to snprintf, but I don't believe it is actually necessary in this case or beneficial since we are providing the error message.
The rest of the file seems to follow suit with no format specifier when we directly provide the error message as well.
Treece-Burgess
added
the
component-rocm
dbarry9
force-pushed
the
2024.08.21_rocm-disabled-msg
branch
2 times, most recently
from
6dd235b to
6dc29ca
Compare
Treece-Burgess
requested changes
Feb 26, 2025
| @@ -225,7 +225,6 @@ rocm_init_private(void) | |||
| fn_exit: | |||
| _rocm_vector.cmp_info.initialized = 1; | |||
| _rocm_vector.cmp_info.disabled = papi_errno; | |||
| strcpy(_rocm_vector.cmp_info.disabled_reason, ""); | |||
There was a problem hiding this comment.
Why remove this line?
There was a problem hiding this comment.
This line was overwriting the error message with an empty string; I am not sure why it was here.
Previously, in the absence of a ROCm device, the rocm component did not set the string containing the reason that the component was disabled. These changes have been tested with ROCm 6.3.1 on Frontier.
dbarry9
force-pushed
the
2024.08.21_rocm-disabled-msg
branch
from
6dc29ca to
6e1a74f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Previously, in the absence of a ROCm device, the rocm component did not set the string containing the reason that the component was disabled. This corresponds to Issue #220.
These changes have been tested with ROCm 6.3.1 on Frontier.
Author Checklist
Why this PR exists. Reference all relevant information, including background, issues, test failures, etc
Commits are self contained and only do one thing
Commits have a header of the form:
module: short descriptionCommits have a body (whenever relevant) containing a detailed description of the addressed problem and its solution
The PR needs to pass all the tests