Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update lint #415

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Update lint #415

wants to merge 3 commits into from

Conversation

robertdstein
Copy link
Member

Bump black version, add isort for prettifying dependencies, add option for pre-commit.

Nearly every file is affected by this PR, but the changes in almost all files are cosmetic.

@robertdstein robertdstein requested a review from JannisNe January 29, 2025 15:34
@JannisNe
Copy link
Collaborator

JannisNe commented Jan 29, 2025

I think we should do this. However, this could be a potential nightmare for people doing analyses right now and have modified their flarestack. In that case merging the these changes into main will result in many, many conflicts. As far as I am aware, this could affect @sathanas31, @TeresaPernice and also @mlincett. I will check that any potential PRs are done in the next couple of days before we proceed with this, if there is no urgency, @robertdstein.

@robertdstein
Copy link
Member Author

Sure, no urgency and you can also just close this PR if it's not helpful.

@mlincett
Copy link
Collaborator

No blockers from my side.

(If we need to touch this again in the future, I would suggest looking at ruff that I have used in other situations to replace black and flake8).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants