Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parse RDATE lines in iCal parser #411

Merged
merged 4 commits into from
Aug 15, 2017
Merged

Parse RDATE lines in iCal parser #411

merged 4 commits into from
Aug 15, 2017

Conversation

seejohnrun
Copy link
Collaborator

Closes #409

@seejohnrun seejohnrun requested a review from avit August 14, 2017 07:30
@avit
Copy link
Collaborator

avit commented Aug 14, 2017 •
edited
Loading

This is using standard Time.parse but in your other pull request we switch the parser. Maybe this should be wrapped in TimeUtil.deserialize_time?

@jorroll
Copy link
Contributor

jorroll commented Aug 15, 2017

+10 for this!!!

@seejohnrun
Copy link
Collaborator Author

@avit what do you think of 3b81571 ?

avit
avit approved these changes Aug 15, 2017
View reviewed changes
Copy link
Collaborator

@avit avit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, this works. I'm not sure we needed to extract the separate method for parse_str (the existing deserialize_time would have worked when you pass a string to it)... Did you see the comment related to this method on #408?

@seejohnrun
Copy link
Collaborator Author

Cool - removed the extra layer of indirection

@seejohnrun seejohnrun merged commit e5e78e9 into master Aug 15, 2017
@seejohnrun seejohnrun deleted the parse_rdate branch August 15, 2017 21:52
@seejohnrun seejohnrun mentioned this pull request Aug 21, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avit avit avit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@seejohnrun @avit @jorroll