kyc/quiz: remove transactions #106
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ice-dionysos
force-pushed
the
fix_quiz_tx
branch
2 times, most recently
from
40405e0 to
e3e8852
Compare
ice-dionysos
force-pushed
the
fix_quiz_tx
branch
from
e3e8852 to
67fbdd5
Compare
ice-cronus
reviewed
Jan 29, 2024
|
|
||
| return errors.Wrap(err, "failed to skip session") | ||
| return r.modifyUser(ctx, false, data.EndedAt, userID) |
There was a problem hiding this comment.
I think we need rollback of sql above if this call fails as we dont use transactions here anymore
|
Postponed for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.