Disable NRT warnings for netstandard2.0 (#674)

* Disable NRT warnings for netstandard2.0 Reasoning: netstandard2.0 does not support NRT, so these warnings are useless * Resolve possible null reference in Organizer class
ical-org · Dec 20, 2024 · 4c1de35 · 4c1de35
1 parent 3c5a596
commit 4c1de35
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 2 deletions.
diff --git a/Ical.Net.Tests/Ical.Net.Tests.csproj b/Ical.Net.Tests/Ical.Net.Tests.csproj
@@ -5,6 +5,10 @@
         <AssemblyOriginatorKeyFile>..\IcalNetStrongnameKey.snk</AssemblyOriginatorKeyFile>
         <LangVersion>latest</LangVersion>
     </PropertyGroup>
+    <PropertyGroup Condition="'$(TargetFramework)' == 'netstandard2.0'">
+        <!-- netstandard2.0 does not support NRT -->
+        <NoWarn>$(NoWarn);CS8600;CS8601;CS8602;CS8603;CS8604;CS8618;CS8620;CS8714</NoWarn>
+    </PropertyGroup>
     <ItemGroup>
         <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.11.1" />
         <PackageReference Include="NUnit" Version="4.2.2" />

diff --git a/Ical.Net/DataTypes/Organizer.cs b/Ical.Net/DataTypes/Organizer.cs
@@ -84,7 +84,8 @@ public Organizer(string value) : this()
         }
 
         var serializer = new OrganizerSerializer();
-        CopyFrom(serializer.Deserialize(new StringReader(value)) as ICopyable);
+        if (serializer.Deserialize(new StringReader(value)) is ICopyable deserialized)
+            CopyFrom(deserialized);
     }
 
     protected bool Equals(Organizer other) => Equals(Value, other.Value);
@@ -109,7 +110,7 @@ public override bool Equals(object? obj)
     public override int GetHashCode() => Value?.GetHashCode() ?? 0;
 
     /// <inheritdoc/>
-    public override void CopyFrom(ICopyable obj)
+    public sealed override void CopyFrom(ICopyable obj)
     {
         base.CopyFrom(obj);
 

diff --git a/Ical.Net/Directory.Build.props b/Ical.Net/Directory.Build.props
@@ -13,6 +13,10 @@
         <PackageIcon>assets/icon.png</PackageIcon>
         <PackageReadmeFile>assets/readme.md</PackageReadmeFile>
     </PropertyGroup>
+    <PropertyGroup Condition="'$(TargetFramework)' == 'netstandard2.0'">
+        <!-- netstandard2.0 does not support NRT -->
+        <NoWarn>$(NoWarn);CS8600;CS8601;CS8602;CS8603;CS8604;CS8618;CS8620;CS8714</NoWarn>
+    </PropertyGroup>
     <ItemGroup>
         <None Include="..\readme.md">
             <Pack>true</Pack>