Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude failed cases for OpenJCEPlusFIPS #39

Open
wants to merge 1 commit into
base: openj9
Choose a base branch
from

Conversation

JinhangZhang
Copy link
Contributor

@JinhangZhang
Copy link
Contributor Author

@JasonFengJ9 @jasonkatonica FYI

@JasonFengJ9
Copy link
Member

Does the strict profile also need these changes?

@jasonkatonica
Copy link
Contributor

Most likely we only need these tests excluded in strict mode only, unless they are failing in weak also?

Typically we allow almost all algorithms through in weak mode so i would guess we wouldn't need these changes there.

@JasonFengJ9
Copy link
Member

test/jdk/ProblemList-FIPS140_3_OpenJcePlus.txt

Is this for weak mode?

Solve issue: #21209

Signed-off-by: Jinhang Zhang <[email protected]>
@JinhangZhang
Copy link
Contributor Author

This the weak profile, some of the failed tests are disabled in weak profile because in general the security properties are not allowed to be setup.

@jasonkatonica
Copy link
Contributor

This the weak profile, some of the failed tests are disabled in weak profile because in general the security properties are not allowed to be setup.

This does make sense Jinhang, these tests using security properties should fail in both strict and weak profiles id expect given we dont allow these variables to be set in either profile.

@JasonFengJ9
Copy link
Member

sun/security/provider/NamedEdDSA.java
sun/security/provider/NamedKeyFactoryTest.java

Should these two tests be excluded in either the weak or strict profile?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants