-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't test unavailable algorithms #670
Conversation
Support for EdDSA, Ed25519 and Ed448 was added in Java 15. Signed-off-by: Keith W. Campbell <[email protected]>
Jenkins test sanity.openjdk alinux64 jdk11 |
Strange: the test job didn't use this change; instead it used the current openj9 branch - b33416dc888.
I've launched a grinder instead: https://openj9-jenkins.osuosl.org/job/Grinder/2502. |
https://openj9-jenkins.osuosl.org/job/Grinder/2502/consoleFull
This is a known failure - jdk_security2_0_FAILED javax/crypto/SecretKeyFactory/SecKeyFacSunJCEPrf.java IllegalArgumentException: Key must be at least 160 bits |
I think this is a known issue as well, the test change is not picked up, it was determined a low priority item. FYI @AdamBrousseau |
#669 should fix that failure. |
This may become a more important issue with an increased focus on testing security-related changes. |
Created an issue - ibmruntimes/openj9-openjdk-jdk#613 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - the grinder passed the tests in question.
Support for EdDSA, Ed25519 and Ed448 was added in Java 15.
Fixes: eclipse-openj9/openj9#17579.