forked from openbmc/webui-vue
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated the filter in Dumps #332
Open
Nikhil-Ashoka
wants to merge
1
commit into
ibm-openbmc:1110
Choose a base branch
from
Nikhil-Ashoka:dumps-filter-update
base: 1110
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Nikhil-Ashoka
commented
Jan 7, 2025
- In 1110, The Resource Dump, Hostboot Dump and System Dump shows up as System Dump Entry.
- Checking the dump Id and showing the name as their original type.
- Defect: https://jazz07.rchland.ibm.com:13443/jazz/web/projects/CSSD#action=com.ibm.team.workitem.viewWorkItem&id=670989
Nikhil-Ashoka
force-pushed
the
dumps-filter-update
branch
from
January 8, 2025 07:28
dfa7e2d
to
efeaccb
Compare
- In 1110, The Resource Dump, Hostboot Dump and System Dump shows up as System Dump Entry. - Checking the dump Id and showing the name as their original type. - Defect: https://jazz07.rchland.ibm.com:13443/jazz/web/projects/CSSD#action=com.ibm.team.workitem.viewWorkItem&id=670989 Signed-off-by: Nikhil Ashoka <[email protected]>
Nikhil-Ashoka
force-pushed
the
dumps-filter-update
branch
from
January 8, 2025 07:32
efeaccb
to
234139e
Compare
Nikhil-Ashoka
requested review from
nabilpandiyalayil,
vedangimittal and
tiwari-nishant
January 8, 2025 08:11
asmithakarun
approved these changes
Jan 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure why the dump entries of other types were not included earlier. But this change looks good as it displays all dump types.
nabilpandiyalayil
approved these changes
Jan 15, 2025
vedangimittal
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.