Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle IPv4 address for IPv6 Static Default Gateway #169

Open
wants to merge 1 commit into
base: 1110
Choose a base branch
from

Conversation

kokilavaradhan
Copy link

Error is not thrown when an IPV4 address is provided. This commit addresses the issue by explicitly handling such cases and returning an InvalidArgument error when a IPV4address is configured for IPV6 Static Default Gateway field.

Tested By:
Verified the test case and ensured proper
invalid argument error is thrown.

Change-Id: Ibc3d2a77ae56f5b23c3f8bca12409693aa2f3ad9

Error is not thrown when an IPV4 address is provided.
This commit addresses the issue by explicitly handling such cases
and returning an InvalidArgument error when a IPV4address
is configured for IPV6 Static Default Gateway field.

Tested By:
Verified the test case and ensured proper
invalid argument error is thrown.

Change-Id: Ibc3d2a77ae56f5b23c3f8bca12409693aa2f3ad9
Signed-off-by: kokilav <[email protected]>
@jenkins-openbmc-ibm
Copy link

Can one of the admins verify this patch?

@raviteja-b
Copy link

jenkins run tests please

@raviteja-b raviteja-b self-requested a review January 9, 2025 10:16
@raviteja-b
Copy link

@rfrandse can you please check why CI is not starting on this PR

@rfrandse
Copy link

rfrandse commented Jan 9, 2025

add to approvelist

@rfrandse
Copy link

rfrandse commented Jan 9, 2025

jenkins run tests please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants