Sanyo Denke fan support for BlueRidge 2U #50
Merged
+2,174
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The example wasn't proper JSON. Make it proper with good formatting. Signed-off-by: Matt Spinler <[email protected]> Change-Id: Idbbd7d13357430351162a3e0b0a0ea26c86ff712
The BlueRidge 2U is similar to the Rainier 2U but uses different fans. The only difference from Rainier so far is the fan ceiling is changing from 18000 to 17000. Copy over the Rainier files that reference this and change the values. The groups.json and pcie_cards.json used will still be obtained from the Rainier directory. Signed-off-by: Matt Spinler <[email protected]> Change-Id: Ib935e0d168d6b6cad2f26b5d455aec957af204e5
The BlueRidge 2U is similar to the Rainier 2U but uses different fans. These fans require different factor/offset values. Copy over the Rainier config.json and update these values. Signed-off-by: Matt Spinler <[email protected]> Change-Id: Icad2178559d6fa0cc67105d7112041c4b7c0fec2
There is a period of time in the lab where the BlueRidge 2U will have to support both the ship level and lab-only fan models. To support both with the same factor/offset values, increase the deviation by 4 so that the lab-only fans with the slower outlet rotors won't have faults. After the older lab-only fans have been replaced with the new fans, this can be reverted. Signed-off-by: Matt Spinler <[email protected]> Change-Id: I6fd6bb4bd59651983e7536bfd21d8842a8a88381
spinler
force-pushed
the
blueridge2u_fans
branch
from
e20331b to
8194c39
Compare
|
Upstream reviews are
I don't need to upstream the temporary deviation value. |
smccarney
approved these changes
Jan 8, 2025
derekhoward55
approved these changes
Jan 8, 2025
Yea. It failed CI without that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit copies the Rainier 2U events.json and zones.json and changes the fan ceiling to 17000 from 18000.
The second commit copies the Rainier 2U fan monitor config and changes the factor and offset values, which are used to calculate the expected value for the outlet rotor.
The third commit increases the deviation value in the fan monitor config so that the lab systems with the Delta fans won't get fails. The plan is to replace all existing Delta fans with the new fans when they are available, and then it can be reverted.