Bonnell Fan Updates #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following updates were made to the Bonnell fan control config: - Change max RPMs to 17000 from 18000 - The fans could never actually hit 18000 - Add the real PCIe card list - Update the floor table and the associated parameters - Some unused floor indices are left in the table to make it easier for future expansion. Signed-off-by: Matt Spinler <[email protected]> Change-Id: Ia7f4627f9458322e250452e67f330ede063c7efe
The Bonnell system will support fans from two different vendors where the equation: "tach1_rpm = (target_rpm * factor) + offset" is slightly different between the two. Change the factor and offset values to one that will work for both. Signed-off-by: Matt Spinler <[email protected]> Change-Id: Iffb3f597f4d30b3c3b76edf8950702c0517a59f2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These two commits should be the final updates for Bonnell fan control and monitoring.
They were both merged upstream:
https://gerrit.openbmc.org/c/openbmc/phosphor-fan-presence/+/70578
https://gerrit.openbmc.org/c/openbmc/phosphor-fan-presence/+/70579
One updates the equation for the outlet fan rotor to work for multiple types of fans.
The other changes the max RPM to 17000, and provides the final floor table and hot PCIe card list.