Add 5 second delay before changing floors due to nonfunctional sensors #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add an optional delay field to the count_state_floor action that takes a
value in seconds. When set to a nonzero value, the action will then
require the count condition to be satisfied for that amount of time
before setting the floor. This can be used to prevent the floor from
jumping when there is just short change to a property value, for example
if a sensor set to not functional for a short amount of time.
For example:
{
"name": "count_state_floor",
"count": 1,
"state": false,
"delay": 5,
"floor": 18000
}
This says that the floor won't be set to 18000 until at least 1 group
member has its property value set to false for a continuous 5 seconds.
Signed-off-by: Matt Spinler <[email protected]>
Change-Id: I67409ce651d9592b1cabb3f7cb36ba998c3ef545
Add a 5 second delay to the count_state_floor action that watches for non functional sensors to all IBM configurations. With this change, a sensor has to be nonfunctional for at least 5 seconds for the floor to change. This is being done because the NVMe temperature sensors would briefly be set to nonfunctional when a drive is removed. Signed-off-by: Matt Spinler <[email protected]> Change-Id: I6fa70f2551c11b2cfe8ee4696b6d72d57a3a7bd5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent fans from jumping to the high floor due to temp sensors being nonfunctional for less than 5 seconds.
This fixes a problem when a drive is removed and the NVMe temp sensors briefly go to nonfunctional.
Upstream: https://gerrit.openbmc.org/c/openbmc/phosphor-fan-presence/+/68613
Defect 589453