RBMC: Support for new FSI device driver #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clang-format-19 isn't compatible with the clang-format-18 output, so we need to reformat the code with the latest version. A few parameters in clang-tidy have been deprecated, so adjust the style file accordingly. See Ie2f6eb3b043f2d655c9df806815afd7971fd0947 for updated style. See I88192b41ab7a95599a90915013579608af7bc56f for clang-19 enablement. Change-Id: I47bfd98f41af7fbfdf9ca2d220277427be3c0cfb Signed-off-by: Patrick Williams <[email protected]>
In preparation for a change to the FSI device driver coming that removes the scratchpad register sysfs files in favor of using ioctl(), rename the SysFS class to the Driver class. There are no functional changes. Change-Id: Ibdb7367e8267bd65dd3985b8f3684d9f870ef395 Signed-off-by: Matt Spinler <[email protected]>
RameshIyyar
approved these changes
Jan 30, 2025
There is a new version of the FSI/CFAM device driver. The changes are: - It has ioctl() calls for read/write/writeWithMask which take the register as a number between 0 and 3 and a descriptor for the CFAM device in /dev. - It requires use of a new fsi.h header file which isn't in the kernel yet so it's included locally. The Driver class is updated accordingly. It looks up the /dev file to use by first looking it up in /sys/class/fsi-master/ based on the FSI link number. So that unit tests can still work, there are new functions to return the /dev and /sys/class/fsi-master prefixes so that in test a different version can run that returns temporary directories. Tested: - Everything still works in simulation. Change-Id: I745791937b60a92941f6b30ce0e500c0c1b977cc Signed-off-by: Matt Spinler <[email protected]>
spinler
force-pushed
the
cfam_driver_changes
branch
from
d09047c to
5beff2d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a new version of the FSI device driver which has different CFAM-S scratchpad register interfaces. It now uses ioctl() calls.
The
CFAM: Support new device drivercommit explains the changes in more detail.Also as CI switched to clang-19 a commit for the new .clang-format is included.