Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-7484: unified display of hidden locations in UDW #1428

Merged
merged 2 commits into from
Jan 24, 2025

Conversation

mateuszdebinski
Copy link
Contributor

@mateuszdebinski mateuszdebinski commented Jan 21, 2025

🎫 Issue IBX-7484

After the changes, the hidden element looks like in the screenshots for different views

Screenshot from 2025-01-21 16-08-47
Screenshot from 2025-01-21 16-08-55
Screenshot from 2025-01-21 16-42-30

@mateuszdebinski mateuszdebinski added Bug Something isn't working Ready for review labels Jan 21, 2025
@mateuszdebinski mateuszdebinski requested a review from a team January 21, 2025 15:22
@mateuszdebinski mateuszdebinski self-assigned this Jan 21, 2025
@mateuszdebinski mateuszdebinski force-pushed the IBX-7484_lack_of_consistency_in_displaying_hidden_content branch from 399b68d to 1183bc9 Compare January 21, 2025 15:43
@mateuszdebinski mateuszdebinski requested review from dew326 and a team January 22, 2025 10:47
@tomaszszopinski tomaszszopinski force-pushed the IBX-7484_lack_of_consistency_in_displaying_hidden_content branch from 677d1d7 to 317d0b4 Compare January 24, 2025 09:46
@tomaszszopinski tomaszszopinski self-assigned this Jan 24, 2025
Copy link
Contributor

@glye glye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still think we should remove the Hide feature for misleading users into bad security choices, replacing it with an object state. But as long as we don't, a unified display is good. 👍

Copy link
Contributor

@tomaszszopinski tomaszszopinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA approved on IbexaDXP 4.6 commerce.

@dew326 dew326 merged commit b367a66 into 4.6 Jan 24, 2025
29 checks passed
@dew326 dew326 deleted the IBX-7484_lack_of_consistency_in_displaying_hidden_content branch January 24, 2025 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working QA approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants