-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IBX-7484: unified display of hidden locations in UDW #1428
IBX-7484: unified display of hidden locations in UDW #1428
Conversation
399b68d
to
1183bc9
Compare
src/bundle/Resources/public/scss/ui/modules/content-tree/_list.item.scss
Outdated
Show resolved
Hide resolved
src/bundle/Resources/public/scss/ui/modules/universal-discovery/_finder.leaf.scss
Outdated
Show resolved
Hide resolved
src/bundle/Resources/public/scss/ui/modules/content-tree/_list.item.scss
Show resolved
Hide resolved
src/bundle/Resources/public/scss/ui/modules/content-tree/_list.item.scss
Show resolved
Hide resolved
src/bundle/Resources/public/scss/ui/modules/universal-discovery/_finder.leaf.scss
Show resolved
Hide resolved
src/bundle/Resources/public/scss/ui/modules/universal-discovery/_finder.leaf.scss
Show resolved
Hide resolved
677d1d7
to
317d0b4
Compare
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still think we should remove the Hide feature for misleading users into bad security choices, replacing it with an object state. But as long as we don't, a unified display is good. 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
QA approved on IbexaDXP 4.6 commerce.
After the changes, the hidden element looks like in the screenshots for different views