DiceDB#921: Added Hashmap incrementFloatValue overflow check (DiceDB#927

)
iamskp11 · Oct 5, 2024 · e4258b3 · e4258b3
1 parent 3236511
commit e4258b3
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/internal/eval/hmap.go b/internal/eval/hmap.go
@@ -121,7 +121,7 @@ func (h HashMap) incrementFloatValue(field string, incr float64) (string, error)
 		return "-1", diceerrors.NewErr(diceerrors.IntOrFloatErr)
 	}
 
-	if (i > 0 && incr > 0 && i > math.MaxFloat64-incr) || (i < 0 && incr < 0 && i < -math.MaxFloat64-incr) {
+	if math.IsInf(i+incr, 1) || math.IsInf(i+incr, -1) {
 		return "-1", diceerrors.NewErr(diceerrors.IncrDecrOverflowErr)
 	}
 

diff --git a/internal/eval/hmap_test.go b/internal/eval/hmap_test.go
@@ -116,4 +116,14 @@ func TestHashMapIncrementFloatValue(t *testing.T) {
 	val, err = hmap.incrementFloatValue("field2", 1.0)
 	assert.NotNil(t, err, "Expected error when incrementing a non-float value")
 	assert.Equal(t, errors.IntOrFloatErr, err.Error(), "Expected int or float error")
+
+	inf := math.MaxFloat64
+
+	val, err = hmap.incrementFloatValue("field1", inf+float64(1e308))
+	assert.NotNil(t, err, "Expected error when incrementing a overflowing value")
+	assert.Equal(t, errors.IncrDecrOverflowErr, err.Error(), "Expected overflow to be detected")
+
+	val, err = hmap.incrementFloatValue("field1", -inf-float64(1e308))
+	assert.NotNil(t, err, "Expected error when incrementing a overflowing value")
+	assert.Equal(t, errors.IncrDecrOverflowErr, err.Error(), "Expected overflow to be detected")
 }