Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue #129 #130

Merged
merged 1 commit into from
Apr 17, 2024
Merged

Fix issue #129 #130

merged 1 commit into from
Apr 17, 2024

Conversation

fs-sifat
Copy link
Contributor

What is it?

  • Bugfix (user facing)
  • Feature request (user facing)
  • Codebase improvement (dev facing)

Description of the changes in your PR

  • Toggle viewPager.isUserInputEnabled when ToDoManager is focused and unfocused, so that the user can't swipe to another window

Flaws

  • Does expose a private variable(viewPager in LauncherActivity.kt) to public

Fixes the following issue(s)

@iamrasel
Copy link
Owner

iamrasel commented Apr 4, 2024

As I am unable to produce such issue on my device, I can't check if this solves the issue. But I do hope for something better.

@fs-sifat
Copy link
Contributor Author

fs-sifat commented Apr 8, 2024 •
edited
Loading

As I am unable to produce such issue on my device, I can't check if this solves the issue. But I do hope for something better.

To reproduce the issue, simply swipe left/right while the todo manager is visible.

@iamrasel iamrasel merged commit 1678004 into iamrasel:main Apr 17, 2024
1 check passed
@fs-sifat fs-sifat deleted the todoman-fix branch April 17, 2024 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamrasel iamrasel iamrasel left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fs-sifat @iamrasel