GoogleMaps support

[mdastous-bentley]

No description provided.

[pmconne]

See if you can avoid reinventing JSONSchema.

[mdastous-bentley]

export type JSONSchemaType = string | number | boolean | object | JSONSchemaType[];

I need a type representing types that can be directly serialized and can be compared easily. This is why I excluded object, and I didn't want to support array of arrays.

Is there a way to compose type from existing types with typescript ?

[pmconne]

Do the google maps property bags definitely conform to those constraints? Do we anticipate other map providers that might not meet those constraints?

[mdastous-bentley]

Currently for google it only holds this data structure:

export interface CreateGoogleMapsSessionOptions {
  mapType: GoogleMapsMapType;
  language: string;     
  region: string;    
  orientation?: number;
  layerTypes?: string[];
};

My thinking is that MapLayerSettings's properties are meant to be simple list key,value pairs that can be passed down to the provider, it's not meant to pass complex data structures. If nested objects need to be passed, it can always be simplified into a flat list of values and re-construct inside the provider.

[mdastous-bentley]

@pmconne Part of this PR, I need to have an async version of TileTreeReference.addLogoCards, mainly because a request need to Google web API is required to retrieve copyright strings associated with selected tiles. Currently it's being invoked through Viewport.forEachTileTreeRef, which is not async.

My only solution right now, would consist in created an async version of the forEach methods, but I feel like it will result in a ugly API.

Any thoughts?

[pmconne]

My only solution right now, would consist in created an async version of the forEach methods, but I feel like it will result in a ugly API.

The forEach methods are a relic of the days when we were still learning how to do TypeScript.
I'd suggest supplanting them with synchronous method(s) that return Iterable<TileTreeReference>. Then the caller can worry about calling async methods on the references, halting iteration partway through, doing something with the return value of whatever he's calling on the references, etc etc.

[pmconne]

Why absolute value? It breaks the strict weak constraint.