Elevate BackendHubAccess to public, remove deprecated 3.x APIs in core-backend #7587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hl662
commented
Jan 22, 2025
| export interface BackendHubAccess { | ||
| // @internal | ||
| acquireLocks: (arg: BriefcaseDbArg, locks: LockMap) => Promise<void>; | ||
| acquireNewBriefcaseId: (arg: AcquireNewBriefcaseIdArg) => Promise<BriefcaseId>; | ||
| createNewIModel: (arg: CreateNewIModelProps) => Promise<GuidString>; | ||
| deleteIModel: (arg: IModelIdArg & ITwinIdArg) => Promise<void>; | ||
| downloadChangeset: (arg: DownloadChangesetArg) => Promise<ChangesetFileProps>; |
There was a problem hiding this comment.
@GytisCepk I ran extract-api and it threw warnings for 2 methods, saying it uses args (DownloadChangesetArg and DownloadChangesetRangeArg) that are marked as @beta for this API I just converted to @public... git blame showed you most recently worked on this, do you think those args are okay to move to public or should we move BackendHubAccess to @beta instead
There was a problem hiding this comment.
I expect DownloadChangesetRangeArg to break due to #7357. So we might mark it @public to just deprecate it soon after.
That being said, if there is no other concerns about making BackendHubAccess public, I would go ahead and mark both DownloadChangesetArg and DownloadChangesetRangeArg public.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
publicBackendHubAccessinterface topublicNotes:
TODO: