Attempt to load/create WW15MGH._96 even if writable directory cannot be resolved #946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EimantasMorkunas
requested review from
AlainRobertAtBentley and
tcobbs-bentley
|
|
EimantasMorkunas
force-pushed
the
eimantas/csmap-rw-dir
branch
from
aaf82b2 to
54d1a26
Compare
tcobbs-bentley
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix https://github.com/iTwin/itwinjs-backlog/issues/1118.
The binary shadow file should exist in cloud cache workspace (
bTime = CS_fileModTime (__This->binaryPath)below the changed code should return non-zero value) so it should be irrelevant if writable directory is available. TheCS_rwDictDir()function copies source path to the result so the binary path should be valid even in case of an error.If cloud cache is not used or binary file does not exist and a writable directory is not available, the code should still error out when attempting to create the binary file.