Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Electron 28 #223

Merged
merged 12 commits into from
Jan 17, 2024
Merged

Add support for Electron 28 #223

merged 12 commits into from
Jan 17, 2024

Conversation

GytisCepk
Copy link
Contributor

No description provided.

Copy link
Member

@aruniverse aruniverse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the min node ver for electron 23?

@GytisCepk
Copy link
Contributor Author

What's the min node ver for electron 23?

18.12 (Electron Node table)

@GytisCepk
Copy link
Contributor Author

Tests are failing due to a bug in Playwright. Need to wait for a new release of Playwright.

More info: microsoft/playwright#28048

@GytisCepk GytisCepk enabled auto-merge (squash) January 17, 2024 09:38
@GytisCepk GytisCepk merged commit cd0b407 into main Jan 17, 2024
11 of 13 checks passed
@GytisCepk GytisCepk deleted the gytis/Electron-28-support branch January 17, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants