fix (controls): add an offset after mouse movement #611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gchoqueux
reviewed
Jan 8, 2018
| @@ -904,8 +904,13 @@ function GlobeControls(view, target, radius, options = {}) { | |||
|
|
|||
| event.preventDefault(); | |||
|
|
|||
| const staticPos = window.getComputedStyle(event.target.parentElement).position !== 'static'; | |||
There was a problem hiding this comment.
could you factorize this part that appears several times?
There was a problem hiding this comment.
Nope, it depends on the event, and this variable is available in the function scope only. As GlobeControls is a sort of singleton (correct me if I'm wrong), we can't compute the value at the init of the class.
There was a problem hiding this comment.
Ok, you could pass the event as a parameter.
In short, it isn't important.
|
@elias75015 can you test if the bug is fixed? |
When moving the globe using GlobeControls, there was some kind of offset, the globe not staying right under the cursor. This is visible if the container of the canvas is not occupying the full page, the container has a CSS position property different of the default 'static' and there are elements right before it on the page, like the geoportal case. The solution to avoid this, is to detect the position of the container and add an offset according to this position, using the getBoundingClientRect method of the container.
zarov
force-pushed
the
fix-globe-controls-offset
branch
from
cec996c to
bf71599
Compare
|
The following bugs have been corrected :
|
gchoqueux
approved these changes
Jan 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When moving the globe using
GlobeControls, there was some kind of offset, the globe not staying right under the cursor. This is visible if the container of the canvas is not occupying the full page, the container has a CSS position property different of the defaultstaticand there are elements right before it on the page, like the geoportal case.The solution to avoid this, is to detect the position of the container and add an offset according to this position, using the
getBoundingClientRectmethod of the container.@elias75015 could you test this fix ?
Note: as I tweaked the
GlobeControls, I can confirm that we need to resolve issue #545, as there were some other bugs as well.