-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(PointCloudLayer) add points filtre based on classification #2374
base: master
Are you sure you want to change the base?
Conversation
f024a73
to
fa74f28
Compare
I see we're using a conditional discard in the fragment shader; it might be worth benchmarking the performance of this against using a transparent color or performing the filtering earlier on CPU (which, given the right optimization work, might turn out to be the best solution). |
fa74f28
to
a0b6f14
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need another review.
8c6da4c
to
fdafc57
Compare
fdafc57
to
f5870a3
Compare
f5870a3
to
8716bd7
Compare
874efb2
to
2297d27
Compare
Any classification scheme used for PointCloudLayer havea property 'visible' for each class.
This PR aims at using this value to filter point whichever the visualization mode choosen.
In other word, if a class has its property 'visible' set to false, we want to discard all points having the value in the rendering, (even if we choose to use the 'intensity' rendering)
In this PR, I used migrate all PointCloud examples to lilGUI instead of datGUI