Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update THREE.js to r101.1 #1026

Merged
merged 1 commit into from
Feb 7, 2019
Merged

Conversation

gchoqueux
Copy link
Contributor

@gchoqueux gchoqueux commented Feb 4, 2019

Description

  • FirstPersonControls.lookAt(). lat, lon, phi, theta and target were removed from the public API. FirstPersonControls also respects the initial camera orientation now. => nothing use FirstPersonControls, it is rewrited in iTowns
  • MeshStandardMaterial and MeshPhysicalMaterial now preserve energy for IBL lighting, resulting in brighter, more accurate colors for metallic materials with high roughness values when lit via a map generated by PMREMGenerator. => No impact
  • Scene Introduce .dispose(). => we can use this function with the architecture in layer
  • Added support for Multisampled Renderbuffers. => I open a specific issue on this subject Question about support for Multisampled Renderbuffers in THREE 101 #1028, because it can be very interesting.

@gchoqueux gchoqueux added wip 🚧 Still being worked on chore 🚚 labels Feb 5, 2019
@gchoqueux gchoqueux added this to the 2.8.0 milestone Feb 6, 2019
@gchoqueux gchoqueux added ready and removed wip 🚧 Still being worked on labels Feb 7, 2019
@zarov
Copy link
Contributor

zarov commented Feb 7, 2019

nothing use FirstPersonControls, it is rewrited in iTowns

@gliegard please have a look on how it has evolved, as it is you who worked recently on this

we can use this function with the architecture in layer

Ok, let's open an issue about it.

@zarov zarov merged commit ce002f7 into iTowns:master Feb 7, 2019
@gchoqueux gchoqueux deleted the three_101.1 branch February 7, 2019 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants