-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework GlobeControls #545
Comments
Yes! A basic idea: the new It might be necessary to add other anchors for FrameRequester in MainLoop (being called before rendering, after rendering, before update, after update etc...) to be able to do everything we want (without having to setup timeout, promises on command-empty, or dummy frame requesters). Last but not least, I think we can work incrementally by having a GlobeControls2.js, and replacing the former GlobeControls once we reach feature parity, instead of trying to rewrite everything in one PR. |
In PR #545 updateCameraTransformation is missing setCameraTargetPosition
Since #795, Globe Controls has been greatly refactoring and debugging.
|
The GlobeControls class has evolved a lot since the creation of itowns2. It is of great help but it is getting very messy with 2000 lines of delicious spaghetti.
A complete refactorization is necessary.
The text was updated successfully, but these errors were encountered: