refactor(temp): test ?

iTowns · May 21, 2024 · a2e5fa1 · a2e5fa1
1 parent c6b7710
commit a2e5fa1
Showing 1 changed file with 10 additions and 3 deletions.
diff --git a/src/Layer/ReferencingLayerProperties.js b/src/Layer/ReferencingLayerProperties.js
@@ -1,7 +1,6 @@
 
 // next step is move these properties to Style class
 // and hide transparent mechanism
-
 function ReferLayerProperties(material, layer) {
     if (layer && layer.isGeometryLayer) {
         let transparent = material.transparent;
@@ -16,26 +15,31 @@ function ReferLayerProperties(material, layer) {
                 get: () => material.layer.opacity,
             });
         }
+
         if (material.uniforms && material.uniforms.mode != undefined) {
             Object.defineProperty(material.uniforms.mode, 'value', {
                 get: () => material.layer.pntsMode,
             });
         }
+
         if (material.uniforms && material.uniforms.shape != undefined) {
             Object.defineProperty(material.uniforms.shape, 'value', {
                 get: () => material.layer.pntsShape,
             });
         }
+
         if (material.uniforms && material.uniforms.sizeMode != undefined) {
             Object.defineProperty(material.uniforms.sizeMode, 'value', {
                 get: () => material.layer.pntsSizeMode,
             });
         }
+
         if (material.uniforms && material.uniforms.minAttenuatedSize != undefined) {
             Object.defineProperty(material.uniforms.minAttenuatedSize, 'value', {
                 get: () => material.layer.pntsMinAttenuatedSize,
             });
         }
+
         if (material.uniforms && material.uniforms.maxAttenuatedSize != undefined) {
             Object.defineProperty(material.uniforms.maxAttenuatedSize, 'value', {
                 get: () => material.layer.pntsMaxAttenuatedSize,
@@ -45,11 +49,14 @@ function ReferLayerProperties(material, layer) {
         Object.defineProperty(material, 'wireframe', {
             get: () => material.layer.wireframe,
         });
+
         Object.defineProperty(material, 'transparent', {
             get: () => {
-                if (transparent != (material.layer.opacity < 1.0 || transparent)) {
+                const needTransparency = material.userData.needTransparency?.[material.mode] || material.layer.opacity < 1.0;
+                console.warn('needTransparency', needTransparency);
+                if (transparent != needTransparency) {
                     material.needsUpdate = true;
-                    transparent = (material.layer.opacity < 1.0 || transparent);
+                    transparent = needTransparency;
                 }
                 return transparent;
             },