Use extended OSd glyphs for dot in numbers #10614
Conversation
src/main/io/osd.c
Outdated
| uint8_t symbol_mi = SYM_MI; | ||
| uint8_t symbol_nm = SYM_NM; | ||
|
|
||
| if(useRichSymbols) |
There was a problem hiding this comment.
Do we need this? Can't we always use the same symbols?
There was a problem hiding this comment.
Second number of ADSB warning OSD element is altitude diff, I was not sure if it's OK to use "dis/km" OSD element. For horizontal distance INAV use "dis/km", for altitude "alt/km", but there is no element for altitude diff.
Originaly it was without unit, I don't think it's OK.
Do you have any suggestion how ADSB warning should look? I'm open to any suggestion.
There was a problem hiding this comment.
There is a suffix and a bunch of other elements on that particular item, right? I think part of the reason for different symbols for distance/km and altitude/km is the silly mix of units used in aviation.... :)
Just check the units options for the OSD.
It should be ok to use dis/km for horizontal distance and alt/km for vertical difference.
You can probably look at the radar osd element for consistency, but they may be ommiting the distance units for brevity. The analog osd canvas is a lot smaller than the hd osd canvas, which is probably the motivation for the compressed decimal symbol as well.
There was a problem hiding this comment.
would you be OK with?
BTW: inav radar does not use units as I know
There was a problem hiding this comment.
Looks ok for me. @MrD-RC any feedback on this?
|
BTW, if you want to aim for 8.1.x, you should target maintenance-8.x.x branch instead of master in your pr. |
error414
force-pushed
the
adsb-better-look
branch
from
0bd7871 to
a4ded42
Compare
|
Now it looks exactly like on screen
|
Inav Configurator #PR iNavFlight/inav-configurator#2311